Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: jobs: make the registry logging less chatty #89104

Closed
wants to merge 1 commit into from
Closed

release-22.1: jobs: make the registry logging less chatty #89104

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2022

Backport 1/1 commits from #89064 on behalf of @knz.

/cc @cockroachdb/release

The "toggling idleness" log message was the 4th most voluminous log event source in CC, logged 4x more frequently than the first next event source in volume.

This commit makes it less verbose.

Release note: None

Release justification:

@knz
jobs: make the registry logging less chatty
8f2793f 
The "toggling idleness" log message was the 4th most voluminous log
event source in CC, logged 4x more frequently than the first next
event source in volume.

This commit makes it less verbose.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 30, 2022 17:33
@blathers-crl blathers-crl bot requested review from shermanCRL and removed request for a team September 30, 2022 17:33
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-89064 branch from c47d912 to 8f2793f Compare September 30, 2022 17:33
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 30, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Sep 30, 2022

dup #89073

@knz knz closed this Sep 30, 2022
@knz knz deleted the blathers/backport-release-22.1-89064 branch September 30, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shermanCRL shermanCRL Awaiting requested review from shermanCRL shermanCRL is a code owner automatically assigned from cockroachdb/cdc-prs

@ajwerner ajwerner Awaiting requested review from ajwerner

@dt dt Awaiting requested review from dt

@knz knz Awaiting requested review from knz

@miretskiy miretskiy Awaiting requested review from miretskiy

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@knz knz

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @knz